Repository navigation
Conversation
Replace the point-sampling approach with exact intersection of each trajectory segment against the mesh faces. Faces are triangulated as a fan around the face centroid (watertight between neighboring cells) and a uniform bucket grid limits the faces tested per segment. The crossing direction at each intersection determines which cell is entered, so each part of the trajectory between consecutive crossings is assigned to a single cell. Multiple crossings of the same non-planar face are handled. - Cells are returned in order of first visit, as before. - extra_out lengths are now exact, and a new :centroids entry gives the length-weighted centroid of the subsegments in each cell. - Fix :normed_direction using the list index instead of the cell index in cell_dims. - `n` and `limit_box` are kept for backwards compatibility but no longer have an effect. - Roughly 100x faster than the previous version on a 500k-cell mesh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
==========================================
- Coverage 57.22% 57.13% -0.09%
==========================================
Files 222 211 -11
Lines 29847 29655 -192
==========================================
- Hits 17079 16944 -135
+ Misses 12768 12711 -57 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the point-sampling approach with exact intersection of each trajectory segment against the mesh faces. Faces are triangulated as a fan around the face centroid (watertight between neighboring cells) and a uniform bucket grid limits the faces tested per segment. The crossing direction at each intersection determines which cell is entered, so each part of the trajectory between consecutive crossings is assigned to a single cell. Multiple crossings of the same non-planar face are handled.
nandlimit_boxare kept for backwards compatibility but no longer have an effect.