Add Python bindings for peptide property prediction models#4
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: singjc <32938975+singjc@users.noreply.github.com>
Co-authored-by: singjc <32938975+singjc@users.noreply.github.com>
Co-authored-by: singjc <32938975+singjc@users.noreply.github.com>
Co-authored-by: singjc <32938975+singjc@users.noreply.github.com>
|
@copilot can you update this PR with the recent changes in the develop branch. Also DO NOT INCLUDE any build files in the PR. You seem to have added the full |
Co-authored-by: singjc <32938975+singjc@users.noreply.github.com>
Co-authored-by: singjc <32938975+singjc@users.noreply.github.com>
Done in commit
The Python bindings compile successfully against the updated |
|
@copilot, Can you change the target receiving branch. We would want to merge this PR into develop, not the master branch. |
Changing a PR's base branch is a GitHub UI action that I'm not able to perform directly. You can update it yourself by going to the PR page, clicking the Edit button next to the PR title, and changing the base branch from |
|
@copilot Okay, I changed the base branch to develop for this PR to be merged into. There seem to be a lot of files be referenced as changed though, when the changes merged from the develop branch? These shouldn't be in the revision log since you just merged the changes from develop? This was the case previously because develop has a lot more changes that the master branch. |
…indings feature Co-authored-by: singjc <32938975+singjc@users.noreply.github.com>
The PR diff against
GitHub's PR diff (base: |
|
@copilot it's still showing all the changed files from the merged develop. Can you maybe create a new PR with only the i ntentional Python-bindings additions (crates/redeem-properties-py/), and make sure the base branch of that PR is the develop branch |
Co-authored-by: singjc <32938975+singjc@users.noreply.github.com>
I've prepared a clean branch To get the clean PR you're after, you have two options: Option A — Push the clean branch I prepared: git fetch origin
git checkout -b copilot/python-bindings-clean origin/develop
git checkout origin/copilot/add-peptide-prediction-crate -- \
.gitignore Cargo.toml README.md crates/redeem-properties-py/
git commit -m "feat: Add Python bindings for peptide property prediction models"
git push origin copilot/python-bindings-cleanThen open a new PR from Option B — Squash this PR on merge: When merging the current PR, use "Squash and merge" which will collapse all the commits into one and the Files Changed tab already shows only the correct 8 files (verified with Also fixed the Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot can you summarize the goal and what was done in this PR, to generate a new prompt for another copilot agent to work on this from scratch/fresh. |
Here is a prompt a fresh agent can use to implement this from scratch cleanly: Goal: Create a new Python package crate Repository: What to build: Create
Other file changes (minimal, on top of develop):
Key API notes from the existing Rust code:
Verification: Run |
Exposes RT, CCS, and MS2 prediction models to Python via PyO3 bindings, enabling Python users to leverage ReDeeM's deep learning models without reimplementation.
Implementation
New crate:
redeem-properties-pyRTModel: Retention time prediction (rt_cnn_lstm, rt_cnn_tf)CCSModel: Collision cross-section prediction (ccs_cnn_lstm, ccs_cnn_tf)MS2Model: MS2 fragment intensity prediction (ms2_bert)Key features:
Changes
crates/redeem-properties-py/— new PyO3 crateCargo.toml— addredeem-properties-pyto workspaceREADME.md— Python usage section.gitignore— exclude build artifactsOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.