Skip to content

UI pop-up bug fix when opponent disconnects while you are waiting for him to respond to a blocking action #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DragosIonita23 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

UI pop-up bug fix when opponent disconnects while you are waiting for him to respond to a blocking action #418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/duel-interface/Duel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,20 @@ export function Duel({
};
}, [duelFinished, onDuelFinished]);

// A disconnect (either side) can happen while this player is still waiting
// on the opponent's action (their turn, a block decision, etc.). Nothing
// ever sends a matching end_wait for that, so without this the "Wait"
// popup stays open on top of "Opponent Disconnected"/"Disconnected" and
// hides their Leave Duel button, since all three share the same z-index
// and "Wait" renders later in the DOM.
useEffect(() => {
if (!opponentDisconnected && !reconnecting) {
return;
}

setWait("");
}, [opponentDisconnected, reconnecting]);

const duelFinishedWinner =
duelFinished?.winner?.username ?? duelFinished?.winner?.uid ?? "No winner";

Expand Down
Loading