Skip to content

Ulex the Dauntless - #407

Open
DragosIonita23 wants to merge 2 commits into
sindreslungaard:mainfrom
DragosIonita23:wonkerdrg/ulex-the-dauntless
Open

Ulex the Dauntless#407
DragosIonita23 wants to merge 2 commits into
sindreslungaard:mainfrom
DragosIonita23:wonkerdrg/ulex-the-dauntless

Conversation

@DragosIonita23

Copy link
Copy Markdown
Contributor

📝 Summary

Added Ulex the Dauntless

🎴 New Cards Added

  • Ulex the Dauntless

🐞 Bugs Fixed

🔧 Other Changes

✅ Checklist

Please confirm the following before submitting your PR:

  • I have read CONTRIBUTING.md
  • The changes has been tested locally
  • Tests are written that covers the changes made and any bugs fixed (./sim/tests)

📸 Screenshots (if applicable)

If there are any visual changes to the frontend, please include some screenshots or screen recordings of it

@sindreslungaard sindreslungaard left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this implementation will work because there are so many cards that directly set c.Tapped = true without using these fx helpers.

I did look into implementing this when doing the big batch of dm-11 and dm-12 cards and I think the best solution is to create a new player.TapCard(card *Card) function and update the entire codebase to only use this for tapping cards, then put the condition check inside of that new function

@DragosIonita23

Copy link
Copy Markdown
Contributor Author

I don't think this implementation will work because there are so many cards that directly set c.Tapped = true without using these fx helpers.

I did look into implementing this when doing the big batch of dm-11 and dm-12 cards and I think the best solution is to create a new player.TapCard(card *Card) function and update the entire codebase to only use this for tapping cards, then put the condition check inside of that new function

Pushed new changes for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants