Contribute ImportEntraIDApplicationProxy-SingleApp.ps1 - #15
Open
matsimon wants to merge 6 commits into
Open
Conversation
…cript Use ImportAzureADApplicationProxy.ps1 as startin point for a updated variant that allows updating a single application.
Switched to ClientId and ClientSecret references, start replacing authentication to not depend on the ClientId of Microsoft Azure PowerShell.
Replace CertPass by PfxPass
TenantId got forgotten previously. It's pretty much mandatory with custom app registrations.
… checking Powershell 5 is unfortunately not reliable in many case for the use with Microsoft.Graph modules thus force usage of pwsh.exe. Add more granular checks for the required Cmdlets so that we don't tell users to install the full Microsoft.Graph(.Beta) module collection
Finally switch over to targeting specific app registrations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, really appreciate the work of all those who worked on win-acme and now simple-acme.
Where I'm coming from
I was considering ImportAzureADApplicationProxy.ps1 as a means of automating several app registrations in a tenant that has not only several of these but with various domains so the current method of this script is likely to reach its limits (having multiple Wildcards). And also in this situation I actually would not want to have one single certificate for all proxied applications.
What this tries to attempt
We can authenticate with client ID and client secret - like the Azure DNS validation plugin already supports and install specific certificates for various proxied applications this way.
I am actually considering using the same (though longer) parameter names as used by the Azure DNS plugin such as
azuretenantidinstead of tenantid.Current state of the PR
This is likely not yet good enough for an upstream contribution and will need some additional testing. A quick-and-dirty variant has been tested in a PoC. Looking forward to your feedback.