[puppetsync] Fix hiera.yaml write race in spec_helper - #120
Merged
michael-riddle merged 1 commit intoAug 24, 2026
Conversation
Every parallel_spec worker's before(:all) hook rewrote the shared spec/fixtures/hieradata/hiera.yaml in place; a catalogue compile in another worker during the truncation window saw an empty hiera config and silently dropped all custom hieradata, producing random hieradata-not-applied spec failures across the fleet. hiera.yaml is now written atomically (write + rename). See simp/puppetsync#90; validated on simp/pupmod-simp-simplib#363.
silug
force-pushed
the
puppetsync/20260820-spec-helper-race
branch
from
August 24, 2026 14:52
377546c to
eb3e512
Compare
michael-riddle
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every parallel_spec worker's before(:all) hook rewrote the shared
spec/fixtures/hieradata/hiera.yaml in place; a catalogue compile in
another worker during the truncation window saw an empty hiera
config and silently dropped all custom hieradata, producing random
hieradata-not-applied spec failures across the fleet. hiera.yaml is
now written atomically (write + rename).
See simp/puppetsync#90; validated on simp/pupmod-simp-simplib#363.