Add prefers-color-scheme dark mode support#106
Open
inspector71 wants to merge 1 commit into
Open
Conversation
The generated transcript pages only defined light-mode colors via CSS custom properties on :root, so they stayed light-background even when the viewer's OS/browser was in dark mode. Add a @media (prefers-color-scheme: dark) block that overrides those same custom properties with dark equivalents, so pages generated by generate_html follow the viewer's theme automatically with no new CLI flag needed.
inspector71
changed the title
prefers-color-scheme dark mode support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:root, so they stayed light-background regardless of the viewer's OS/browser theme.@media (prefers-color-scheme: dark)block that overrides the same CSS custom properties with dark equivalents — no new CLI flag, existing output just follows the viewer's theme.Test plan
test_dark_mode_media_query_present(TDD: confirmed it failed before the CSS change, passes after)<style>block (--snapshot-update), verified the diff is limited to the new CSS linesuv run pytest— 123 passedblack .— no changes needed