roadmap: what a Zed submodule pin bump has to check - #82
Merged
Conversation
Repointing the pin at a commit on main fixed the reviewer's request and broke the build, because moving a submodule moves every file inside it. The Zed registry pins the extension's version in its own extensions.toml and checks it against the extension.toml the pin carries, and the two had drifted apart since July. Both numbers move together, and the Zed extension tracks the grammar's version rather than the compiler's, so they are never the same number. Also records that the loud cargo error in that job's log is benign, since it appears identically in the run that passed and cost time to rule out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folds today's second Zed lesson into the ledger entry that already carries the first.
Repointing the submodule at a commit on
mainsatisfied the reviewer and broke thepackagecheck:Moving a submodule pin moves every file inside it, including
editors/zed/extension.toml, whoseversiontheirpackage-extensionsscript validates against theversionin their ownextensions.toml. Those had agreed in July and drifted since. Fixed by bumping their entry; the check now passes and packages the extension.The entry now records three things a future pin bump needs:
mainIt also records that the loud
could not find Cargo.tomlerror in that job's log is benign. It appears identically in the July run that passed, and the real failure is ten lines below it. That cost real time to rule out and would cost it again.