Skip to content

Remove pysmurf-slac as direct dependency#1077

Merged
BrianJKoopman merged 1 commit into
mainfrom
koopman/pysmurf-3.10
Jun 22, 2026
Merged

Remove pysmurf-slac as direct dependency#1077
BrianJKoopman merged 1 commit into
mainfrom
koopman/pysmurf-3.10

Conversation

@BrianJKoopman

@BrianJKoopman BrianJKoopman commented Jun 18, 2026

Copy link
Copy Markdown
Member

Description

This PR removes pysmurf-slac as a direct dependency in socs.

We need simonsobs/sodetlib#510 to be merged before this, so that we don't upgrade to the Rogue 6 version of pysmurf.

Motivation and Context

We've been slowly moving in this direction once we got pysmurf onto PyPI. I was waiting for things to settle out in the Rogue 6 install.

pysmurf recently set a version requirement of Python >= 3.10 [1], so we need to install a compatible version from PyPI. (Pinning the required version in simonsobs/sodetlib#510.)

The base Docker images install pysmurf already, and the dependency really lies in sodetlib, so we'll rely on those installing it properly, rather than also list it here.

How Has This Been Tested?

Built in the CI. Not tested with any system yet.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrianJKoopman BrianJKoopman changed the title Install pysmurf-slac from PyPI Remove pysmurf-slac as direct dependency Jun 22, 2026
pysmurf is not directly imported in socs. We should rely on sodetlib installing
it properly.
@BrianJKoopman

Copy link
Copy Markdown
Member Author

@tristpinsm this is ready for review now. Note that we need simonsobs/sodetlib#510 to be merged first, else we'll pull an 11.x version of pysmurf.

@BrianJKoopman BrianJKoopman merged commit 1a92b27 into main Jun 22, 2026
19 checks passed
@BrianJKoopman BrianJKoopman deleted the koopman/pysmurf-3.10 branch June 22, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants