Remove pysmurf-slac as direct dependency#1077
Merged
Merged
Conversation
pysmurf is not directly imported in socs. We should rely on sodetlib installing it properly.
a3ee0d7 to
680a7bd
Compare
Member
Author
|
@tristpinsm this is ready for review now. Note that we need simonsobs/sodetlib#510 to be merged first, else we'll pull an |
tristpinsm
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
pysmurf-slacas a direct dependency insocs.We need simonsobs/sodetlib#510 to be merged before this, so that we don't upgrade to the Rogue 6 version of pysmurf.
Motivation and Context
We've been slowly moving in this direction once we got
pysmurfonto PyPI. I was waiting for things to settle out in the Rogue 6 install.pysmurf recently set a version requirement of Python >= 3.10 [1], so we need to install a compatible version from PyPI. (Pinning the required version in simonsobs/sodetlib#510.)
The base Docker images install
pysmurfalready, and the dependency really lies insodetlib, so we'll rely on those installing it properly, rather than also list it here.How Has This Been Tested?
Built in the CI. Not tested with any system yet.
Types of changes
Checklist: