fix: sync README's Performance tables to the promoted v0.1.2 numbers - #8
Open
simonsays1980 wants to merge 1 commit into
Open
fix: sync README's Performance tables to the promoted v0.1.2 numbers#8simonsays1980 wants to merge 1 commit into
simonsays1980 wants to merge 1 commit into
Conversation
benchmarks.md is written by bench_release.py --promote, but README.md's tables are a manual paste from that data and were never updated after the v0.1.2 promotion -- both GPU tables were still showing v0.1.1 figures (RTX GAE claimed 6.3x, actually 3.0x). Recomputed both tables directly from the current benchmarks.md. docs/index.md needs no change: it includes this section of README.md verbatim and picks up the fix automatically (verified via mkdocs build --strict). Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
✅ Deploy Preview for rl-triton ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README.md's two Performance tables (H100 and RTX 2000 Ada, plain and with-truncations) still showed v0.1.1 numbers after the v0.1.2 promotion --benchmarks.mdis written directly bybench_release.py --promote, but README's tables are a manual paste that was never redone.main's currentbenchmarks.mdproduction-regime and with-truncations rows at (num_envs=4096, seq_len=128).docs/index.mdneeded no edit -- it includes this section ofREADME.mdverbatim viainclude-markdown, confirmed viamkdocs build --strictthat the corrected numbers render through.Test plan
mkdocs build --strictpasses with no warnings, corrected GAE=3.0x confirmed in the rendereddocs/index.mdoutput.benchmarks.mdbefore merging.