Skip to content

Update _binner.py fix NumPy version (pre-1.22) with percentile #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hvt1609 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update _binner.py fix NumPy version (pre-1.22) with percentile #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions deepforest/_binner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import numpy as np
from sklearn.base import BaseEstimator, TransformerMixin
from sklearn.utils import check_random_state, check_array
from packaging.version import Version

from . import _cutils as _LIB

Expand Down Expand Up @@ -48,9 +49,15 @@ def _find_binning_thresholds_per_feature(
if bin_type == "percentile":
percentiles = np.linspace(0, 100, num=n_bins + 1)
percentiles = percentiles[1:-1]
midpoints = np.percentile(
col_data, percentiles, interpolation="midpoint"
).astype(X_DTYPE)
# Check if it is older than 1.22
if Version(np.__version__) < Version("1.22"):
midpoints = np.percentile(
col_data, percentiles, interpolation="midpoint"
).astype(X_DTYPE)
else:
midpoints = np.percentile(
col_data, percentiles, method="midpoint"
).astype(X_DTYPE)
assert midpoints.shape[0] == n_bins - 1
np.clip(midpoints, a_min=None, a_max=ALMOST_INF, out=midpoints)
# Equal interval in terms of value
Expand Down