fix(trends): respect configured day boundary - #638
Draft
Charlie284 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trends now anchor their date windows to the configured logical day instead of wall-clock midnight. Food totals, water buckets, chart windows, and streak calculations share the existing
DayBoundaryCalcboundary and use calendar-date arithmetic across DST transitions.Type of change
Related issues
Fixes #628
Changes
Screenshots / recordings
Not applicable; there are no visual changes.
Test plan
Steps
flutter analyze: passed with no issues.just test: passed, 966 tests.just format: completed. The pinned formatter also changes 259 files on an untoucheddevelopcheckout, so that unrelated repository-wide churn is not included here.just ci: stopped at itsformat --set-exit-if-changedgate for the same 259-file baseline mismatch; codegen, tests, and analysis were not reached by that recipe. The separate test and analysis commands above passed.Checklist
just format/ 120-char line width).envvalues committedfeat:,fix:,chore:)