chore(l10n): add a retry string for the search screen - #1056
Conversation
Adds searchRetryAfterConnectionLost across all nine ARBs, with the placeholder description on the template as usual.
There was a problem hiding this comment.
🟡 Changes recommended
The newly added l10n key is left as English in the non-English ARBs, and the PR includes large formatting-only churn that obscures the functional change.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a new localization key intended for the food search screen’s “retry after connection lost” action across the app’s ARB-based l10n layer (not yet wired into the UI).
Changes:
- Added
searchRetryAfterConnectionLostto the locale ARBs, with@searchRetryAfterConnectionLostdescription added inintl_en.arb. - Reformatted a number of existing ARB placeholder metadata (
@...) blocks into multi-line objects.
File summaries
| File | Description |
|---|---|
| lib/l10n/intl_en.arb | Adds the new key + template description; also includes substantial placeholder-metadata reformatting. |
| lib/l10n/intl_de.arb | Adds the new key; reflows many existing placeholder-metadata blocks. |
| lib/l10n/intl_cs.arb | Adds the new key; reflows many existing placeholder-metadata blocks. |
| lib/l10n/intl_it.arb | Adds the new key; reflows many existing placeholder-metadata blocks. |
| lib/l10n/intl_pl.arb | Adds the new key; reflows many existing placeholder-metadata blocks. |
| lib/l10n/intl_sk.arb | Adds the new key; reflows many existing placeholder-metadata blocks. |
| lib/l10n/intl_tr.arb | Adds the new key; reflows many existing placeholder-metadata blocks. |
| lib/l10n/intl_uk.arb | Adds the new key; reflows many existing placeholder-metadata blocks. |
| lib/l10n/intl_zh.arb | Adds the new key; reflows many existing placeholder-metadata blocks. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "sourcesEnergyCompensationTitle": "Anrechnung von Trainingskalorien", | ||
| "sourcesEnergyCompensationDescription": "Importierte Trainings werden mit weniger Energie angerechnet, als dein Gerät meldet. Menschen gleichen Sport aus, indem sie den Rest des Tages weniger Kalorien verbrennen – im Mittel etwa 28 %, bei höherem Körperfettanteil mehr. Der Vorschlag stammt aus dieser Forschung und lässt sich unter Einstellungen → Gesundheitsdaten-Sync ändern. Die Energie selbst meldet die App oder das Gerät, das das Training aufgezeichnet hat; sie wird nicht mit der MET-Formel der App berechnet." | ||
| "sourcesEnergyCompensationDescription": "Importierte Trainings werden mit weniger Energie angerechnet, als dein Gerät meldet. Menschen gleichen Sport aus, indem sie den Rest des Tages weniger Kalorien verbrennen – im Mittel etwa 28 %, bei höherem Körperfettanteil mehr. Der Vorschlag stammt aus dieser Forschung und lässt sich unter Einstellungen → Gesundheitsdaten-Sync ändern. Die Energie selbst meldet die App oder das Gerät, das das Training aufgezeichnet hat; sie wird nicht mit der MET-Formel der App berechnet.", | ||
| "searchRetryAfterConnectionLost": "Retry search" |
| "@measureUnitBar": { | ||
| "placeholders": { | ||
| "count": { | ||
| "type": "num" | ||
| } |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 246d2ace96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "sourcesEnergyCompensationTitle": "Započítání kalorií z tréninku", | ||
| "sourcesEnergyCompensationDescription": "Importované tréninky se započítávají s nižší energií, než jakou hlásí zařízení. Lidé cvičení kompenzují tím, že po zbytek dne spálí méně kalorií – v průměru asi 28 %, při vyšším podílu tělesného tuku více. Doporučená hodnota vychází z tohoto výzkumu a lze ji změnit v Nastavení → Synchronizace zdravotních dat. Samotnou energii hlásí aplikace nebo zařízení, které trénink zaznamenalo; nepočítá se vzorcem MET v aplikaci." | ||
| "sourcesEnergyCompensationDescription": "Importované tréninky se započítávají s nižší energií, než jakou hlásí zařízení. Lidé cvičení kompenzují tím, že po zbytek dne spálí méně kalorií – v průměru asi 28 %, při vyšším podílu tělesného tuku více. Doporučená hodnota vychází z tohoto výzkumu a lze ji změnit v Nastavení → Synchronizace zdravotních dat. Samotnou energii hlásí aplikace nebo zařízení, které trénink zaznamenalo; nepočítá se vzorcem MET v aplikaci.", | ||
| "searchRetryAfterConnectionLost": "Retry search" |
There was a problem hiding this comment.
When the new retry action is wired into the search screen, lib/l10n/intl_cs.arb:1317 will display English to Czech users; the same byte-identical value was added to all seven other non-English ARBs (de, it, pl, sk, tr, uk, and zh). Please provide localized values rather than using the English string as a placeholder.
AGENTS.md reference: AGENTS.md:L19-L23
Useful? React with 👍 / 👎.
| "@measureUnitBar": { | ||
| "placeholders": { | ||
| "count": { | ||
| "type": "num" | ||
| } |
There was a problem hiding this comment.
The expansion beginning at lib/l10n/intl_cs.arb:121 changes only the whitespace of existing metadata, and equivalent unrelated reformatting appears throughout all nine modified ARBs; a semantic JSON comparison shows that the retry key is the only content added. Please return these formatting-only hunks so the change remains limited to the new localization entries.
AGENTS.md reference: AGENTS.md:L41-L41
Useful? React with 👍 / 👎.
Disclosure: this was a deliberate probe, and it workedClosing now. The PR description was written neutrally on purpose — Codex reads PR descriptions, so naming the plant would have let it "catch" the issue by reading rather than by applying a rule. Disclosing now that the review has landed, as intended. What was planted: Why on this branch specifically: the #995 review missed it, but that was not evidence the rules failed — Codex reads Result: the rule fired, P1
Citing And it caught a real defect I had not plantedThe second finding is mine, and correct. My script rewrote each ARB with Codex said exactly that — "a semantic JSON comparison shows that the retry key is the only content added" — citing And it avoided the known trapRaw entry counts legitimately differ across these files (1,070 → 1,112) because Also confirmedThe review was automatic — no Nothing here is merged; the key was never wired into the UI. |
|
Closing — probe complete, result recorded above. |
|
To use Codex here, create an environment for this repo. |
Adds
searchRetryAfterConnectionLostto all nine ARBs, with the description on the template.Scratch PR — standing this up to check a repository automation end to end on a branch that carries the current
develop. Not intended to merge; it will be closed once checked, and nothing here is wired into the UI yet.