Repository navigation
fix(deploy): pin Nixpacks Node 22.23 so the Vite 8 build works - #941
Merged
Merged
Conversation
…act overrides follow deps Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NTBz9Dsf82B143eLnbciNm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Dokploy deploy fails:
Nixpacks' own nixpkgs archive pins Node 22.11.0. Vite 8's bundler, rolldown, needs Node >=22.12 for its native binding, so npm treats
@rolldown/binding-linux-x64-gnuas an incompatible optional dependency and silently skips it. Every deploy since the Vite 8 upgrade has failed this way. The site was last deployed in March. (Auto-deploy had also stopped firing; that is being fixed separately with repo webhooks.)What
nixpacks.tomlpinsnodejs_22to a nixpkgs-unstable channel revision giving 22.23.3, prebuilt in the Nix cache. This is the same approach simonlowes and dylan-a-day use. A TODO explains how to bump it to 22.23.4, which has the 21 Oct security fixes, once that version reaches a channel.engines.nodeis now>=22.12.0, so the requirement is explicit.overrides.react/overrides["react-dom"]are now"$react"/"$react-dom"instead of a hard-coded19.2.8. A pinned override makes every Dependabot react bump fail withEOVERRIDE, as it did in dylan-a-day. The existing Dependabotreactgroup keeps the pair together.Verified locally
npm ci✓ ·npm run build✓ (lockfile change: rootenginesonly)Generated by Claude Code