force the foreground color to white for the error background#137
Open
shirne wants to merge 31 commits into
Open
force the foreground color to white for the error background#137shirne wants to merge 31 commits into
shirne wants to merge 31 commits into
Conversation
Collaborator
|
How does this look on a dark background? |
Author
No difference from before. The text color is just white in dark background. This PR only set the error text to white with red or purple background |
This reverts commit 8dae0e8.
This should enable all jobs to run without being cancelled, while also ensuring that the workflow fails in the event of an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before
after