fix: support newer KakaoTalk Mac composer layouts - #8
Open
gmkseta wants to merge 8 commits into
Open
Conversation
Author
|
Additional environment details from the affected machine:
Manual reproduction on this machine before the patch:
Relevant AX evidence captured with Manual verification after this patch:
The last command succeeded on the affected machine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AXButtoninstead ofAXCheckBoxAXOutlineand looser display-name labels instead of onlyAXTable+_NS:18Details
Root cause
On this machine,
kakaocli sendcould still open the target chat, but failed at the final automation step with:The current automation assumes a narrower Accessibility tree than the one exposed by the current KakaoTalk Mac app:
AXButtonAXOutlineAXScrollAreaWhat changed
AXCheckBoxorAXButtonfor thechatroomstab in both send and inspect flowsAXTableandAXOutlineas valid chat list containersAXTextArea/AXTextFieldwithin the top-level non-table scroll area, preferring controls whose description containsEnter a messageDebug evidence
Using
kakaocli inspect --open-chat <chat> --depth 5, the chat window on the affected machine exposes the composer as:The old code only checked direct children of the candidate scroll area once, immediately after the window appeared.
Test plan
swift build -c releasesucceedsswift testpasses./.build/release/kakaocli inspect --open-chat 성준 --depth 5shows the composer AX tree on the affected machine./.build/release/kakaocli send 성준 "[codex-pr-test] upstream clone patched send"succeeds on the affected machine