Resolve app path by bundle id for localized installs (fixes #22) - #27
Open
official-Cheongae wants to merge 1 commit into
Open
Resolve app path by bundle id for localized installs (fixes #22)#27official-Cheongae wants to merge 1 commit into
official-Cheongae wants to merge 1 commit into
Conversation
AppLifecycle.appPath and StatusCommand hardcoded "/Applications/KakaoTalk.app". On a Korean install the app bundle is "카카오톡.app", so status reported "App installed: No" and launch/ automation could not find the app (issue silver-flight-group#22). Resolve the path at runtime via NSWorkspace.urlForApplication(withBundleIdentifier:), falling back to the previous hardcoded path. StatusCommand now reuses AppLifecycle.appPath. Verified: release build clean on macOS 26 / Swift 6.3; resolves to /Applications/카카오톡.app on a Korean install. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AppLifecycle.appPathandStatusCommandhardcoded/Applications/KakaoTalk.app. On a Korean install the bundle is카카오톡.app, sostatusreportedApp installed: Noand launch / AX automation could not locate the app (issue #22). Any localized install name hits the same wall.Fix
NSWorkspace.shared.urlForApplication(withBundleIdentifier:), keeping the hardcoded path as a fallback.StatusCommandnow reusesAppLifecycle.appPathinstead of its own literal.Bundle id (
com.kakao.KakaoTalkMac) is stable across locales, so this works regardless of the localized.appdisplay name.Verification
/Applications/카카오톡.appon a Korean install;statusnow reports the app correctly.