Skip to content

Sort rows across books when aligning if needed#426

Merged
Enkidu93 merged 1 commit into
masterfrom
sort_rows_across_books
Jun 10, 2026
Merged

Sort rows across books when aligning if needed#426
Enkidu93 merged 1 commit into
masterfrom
sort_rows_across_books

Conversation

@Enkidu93

@Enkidu93 Enkidu93 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Port changes from sillsdev/machine.py#309

Fixes #425


This change is Reviewable

@Enkidu93 Enkidu93 requested a review from ddaspit June 9, 2026 20:15
@Enkidu93

Enkidu93 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

(I did this one myself rather than leaving it for copilot since I knew the code would have to be a little different since we don't have access to all the same things in C# since we don't own the scripture library).

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.36066% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.18%. Comparing base (c6e73ef) to head (990fc0d).

Files with missing lines Patch % Lines
src/SIL.Machine/Corpora/TextCorpusEnumerator.cs 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
+ Coverage   73.15%   73.18%   +0.02%     
==========================================
  Files         439      440       +1     
  Lines       36827    36882      +55     
  Branches     5063     5075      +12     
==========================================
+ Hits        26940    26991      +51     
- Misses       8775     8778       +3     
- Partials     1112     1113       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Enkidu93

Enkidu93 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

I can separate the ScrVersExtensions and put the testing-only method in a separate class under '/tests/' if you prefer. We've had this issue sitting open forever: sillsdev/machine.py#174. The fact of the matter is that these tests that were added aren't really the pass-or-fail kind of tests we want. We should consider reviewing the logging from these tests after these newest fixes, identifying any remaining issues, fixing any remaining issues and adding targeted tests for them, and then deleting all of them.

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I would love to get rid of those kinds of tests in the system.

@ddaspit reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

@Enkidu93 Enkidu93 merged commit 98ef6fa into master Jun 10, 2026
4 checks passed
@Enkidu93 Enkidu93 deleted the sort_rows_across_books branch June 10, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port 'Sort rows across books when aligning'

3 participants