Skip to content

Add tests for parsing Paratext project settings#311

Merged
pmachapman merged 1 commit into
mainfrom
empty_translation_info
Jun 11, 2026
Merged

Add tests for parsing Paratext project settings#311
pmachapman merged 1 commit into
mainfrom
empty_translation_info

Conversation

@pmachapman

@pmachapman pmachapman commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Fixes #295


This change is Reviewable

@pmachapman pmachapman requested review from Enkidu93 and ddaspit June 11, 2026 01:08
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.59%. Comparing base (25e2fbf) to head (7dac10b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
+ Coverage   91.56%   91.59%   +0.02%     
==========================================
  Files         355      357       +2     
  Lines       23127    23153      +26     
==========================================
+ Hits        21177    21206      +29     
+ Misses       1950     1947       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 7 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ddaspit).

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 7 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@pmachapman pmachapman merged commit 6fe9e61 into main Jun 11, 2026
14 checks passed
@pmachapman pmachapman deleted the empty_translation_info branch June 11, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port additional updates from 'Handle empty TranslationInfo tag properly when parsing Settings.xml'

4 participants