Skip to content

Port 'Expose Settings.xml Visibility' from machine#310

Draft
Copilot wants to merge 2 commits into
mainfrom
copilot/port-expose-settings-xml-visibility
Draft

Port 'Expose Settings.xml Visibility' from machine#310
Copilot wants to merge 2 commits into
mainfrom
copilot/port-expose-settings-xml-visibility

Conversation

Copilot AI commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Ports changes from sillsdev/machine#412 — exposes the <Visibility> field from Paratext Settings.xml.

Changes

  • ParatextProjectSettings — Added visibility: Optional[str] = None field
  • ParatextProjectSettingsParserBase — Reads <Visibility> element and passes it to the constructor
  • Tests — Added test_parse() to both file and zip parser tests asserting all settings fields; updated _create_settings() helper to include "Public" for visibility
parser = FileParatextProjectSettingsParser(project_path)
settings = parser.parse()
assert settings.visibility == "Public"  # read from <Visibility>Public</Visibility> in Settings.xml

This change is Reviewable

Copilot AI linked an issue Jun 9, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Port relevant changes from pull request 412 to machine.py Port 'Expose Settings.xml Visibility' from machine Jun 9, 2026
Copilot AI requested a review from ddaspit June 9, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port 'Expose Settings.xml Visibility'

2 participants