Feature/appbuilder-grader#84
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| status String? @db.VarChar(255) | ||
| result String? @db.VarChar(2000) | ||
| publisher_id String @db.VarChar(255) | ||
| lambda_request_id String? @db.VarChar(255) |
There was a problem hiding this comment.
Is this the right length limit? I don't know how best to verify this.
There was a problem hiding this comment.
Good catch. This could be a char(36)
| uuid String @id @default(uuid()) @db.Uuid | ||
| project_id Int | ||
| status String? @db.VarChar(255) | ||
| result String? @db.VarChar(2000) |
There was a problem hiding this comment.
Is this the right length limit? I don't know how best to verify this.
There was a problem hiding this comment.
This is an arbitrary number intended to be bigger than any reasonable value. Only an error could be larger and after trimming there should be plenty of information there still. I'm not opposed to changing this though if you want to.
| 'lambda.executionTimeMs': Date.now() - startTime | ||
| }); | ||
|
|
||
| const body = result.Payload ? Buffer.from(result.Payload).toString('utf8') : ''; |
There was a problem hiding this comment.
Passing an empty string to parsePayload will always result in an error. Is this what we want?
There was a problem hiding this comment.
Payload should never be falsey at this point, but if it is, an empty string is falsey on the next line and parsePayload should not run unless I'm missing something.
2 participants
No description provided.