LT-20524: Resolve install directories in silent (/quiet) installs#937
Open
johnml1135 wants to merge 1 commit into
Open
LT-20524: Resolve install directories in silent (/quiet) installs#937johnml1135 wants to merge 1 commit into
johnml1135 wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses LT-20524 by ensuring FieldWorks’ WiX v6 MSI resolves APPFOLDER, DATAFOLDER, and HARVESTDATAFOLDER during silent/basic-UI installs where InstallUISequence is skipped, preventing incorrect install paths (including ICU data path mismatches) and missing shortcuts in enterprise deployment scenarios.
Changes:
- Duplicates the directory-resolution custom actions into
InstallExecuteSequencewith aUILevel < 4guard so they run only whenInstallUISequenceis skipped. - Preserves existing behavior for reduced UI (
/passive,UILevel=4) and full UI installs so user-selected paths are not overridden.
Render comparison artifactsRender snapshot failures were reported in 7e54c819654a run 27306198682.1, but the latest run ab7b82ff6a61 run 27315176964.1 is clean. This comment will be replaced if a future run produces render snapshot failures again. |
Contributor
|
Why are these extra extensions needed in the OfflineBundle but not in the Bundle? |
Run the MSI directory-resolution actions in InstallExecuteSequence for UILevel < 4 so /quiet and /qb resolve the same app and data paths as /passive and full UI. While validating the fix, reconcile the WiX 6 projects and installer evidence scripts so the MSI and bundles can be built and exercised locally again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LT-20524 — FieldWorks fails
to install in
/quietmode (PDQ Deploy / PDQ Connect / Intune).The directory-resolution custom actions (
SetDefDataFolder,VerifyDataPath, and theUse*AppFolder/Use*DataFolder/Use*HarvestDataFolderset) were scheduled only in theInstallUISequence. Windows Installer skips that sequence for silent(
/quiet,/qn) and basic-UI (/qb) installs, soAPPFOLDER,DATAFOLDER, andHARVESTDATAFOLDERwere never assigned.Consequences:
C:\Program Files\FieldWorks9instead ofC:\Program Files\SIL\FieldWorks 9.ICU_DATAlauncher command pointed atC:\ProgramData\SIL\Icu70./passiveworked only because it still ran the reduced-UI sequence.Fix
Schedule the same directory-resolution actions in the
InstallExecuteSequence, guarded byUILevel < 4so they run onlywhen the UI sequence is skipped. Reduced (
/passive) and full UIinstalls continue to resolve these in the
InstallUISequence, so auser-chosen path is never overridden.
While validating the fix, I also reconciled the WiX 6 projects and the
local installer-evidence scripts so the MSI and bundle builds can be run
end to end again from this branch.
A matching change is required in the legacy WiX 3 installer
(
sillsdev/genericinstaller) and is tracked in the paired PR there.Validation
./Build/Agent/commit-messages.ps1./Build/Agent/check-and-fix-whitespace.ps1./build.ps1 -Configuration Release -BuildInstaller -InstallerToolset Wix6 -InstallerOnly -ForceInstallerOnlyOutput/InstallerEvidence/LT20524-*:/quiet: success;APPFOLDER=C:\Program Files\SIL\FieldWorks 9\,DATAFOLDER=C:\ProgramData\SIL\FieldWorks\Projects\,HARVESTDATAFOLDER=C:\ProgramData\SIL\; desktop and Start Menushortcuts target
C:\Program Files\SIL\FieldWorks 9\FieldWorks.exe./qb: success with the same resolved paths and shortcut targets./passive: success with the same resolved paths and shortcuttargets.
paths and shortcut targets.
/quietfails withError 1925, which is expected for aper-machine MSI without administrator rights and is not part of
LT-20524.
removed the installed
FieldWorks.exeand shortcuts.Notes
The separate report that even
/passivefails when launched asLOCAL SYSTEM via PDQ Connect / Intune still looks like a distinct
relative-path or elevation issue and is not addressed here.
This change is