Skip to content

add back key until fixed upstream#224

Merged
gadfort merged 2 commits into
mainfrom
fix-key
Jul 10, 2026
Merged

add back key until fixed upstream#224
gadfort merged 2 commits into
mainfrom
fix-key

Conversation

@gadfort

@gadfort gadfort commented Jul 10, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Improved compatibility with the OpenROAD driver by enabling the typical parasitic extraction model configuration.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@gadfort, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c6866096-6bc2-4c99-81f1-a71073a4db0a

📥 Commits

Reviewing files that changed from the base of the PR and between c47c7a1 and 0570927.

📒 Files selected for processing (1)
  • lambdapdk/gt2n/__init__.py
📝 Walkthrough

Walkthrough

Changes

OpenROAD PEX compatibility

Layer / File(s) Summary
Configure OpenROAD PEX resources
lambdapdk/gt2n/__init__.py
GT2NPDK.__init__ activates openroad.pex and registers the OpenROAD typical PEX model fileset.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is related to the change because it describes restoring a missing key/configuration until an upstream fix lands.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-key

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@lambdapdk/gt2n/__init__.py`:
- Around line 122-125: Add the missing GT2N OpenRCX rules asset at the path
expected by the “openroad”/“typical” fileset, ensuring it is present before the
add_pexmodelfileset("openroad", "typical") call in the
active_fileset("openroad.pex") block.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8c679229-b3fb-44d3-8f29-3e2f6418f5c7

📥 Commits

Reviewing files that changed from the base of the PR and between 9708488 and c47c7a1.

📒 Files selected for processing (1)
  • lambdapdk/gt2n/__init__.py

Comment thread lambdapdk/gt2n/__init__.py
@gadfort gadfort merged commit 95f178f into main Jul 10, 2026
4 checks passed
@gadfort gadfort deleted the fix-key branch July 10, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant