Skip to content

remove old pex#222

Merged
gadfort merged 3 commits into
mainfrom
pex23
Jul 9, 2026
Merged

remove old pex#222
gadfort merged 3 commits into
mainfrom
pex23

Conversation

@gadfort

@gadfort gadfort commented Jul 9, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Simplified OpenROAD PEX setup across multiple PDKs by relying on the rules-based configuration only.
    • Removed outdated RC extraction definitions for several technology corners, helping avoid conflicting or duplicate extraction behavior.
    • Cleaned up interposer, Sky130, GF180, ASAP7, FreePDK45, GT2N, and IHP130 PEX setup files to use a more consistent package layout.

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@gadfort, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 366b83e3-7664-4659-a28e-30f8b238f711

📥 Commits

Reviewing files that changed from the base of the PR and between a957c80 and ea66a04.

📒 Files selected for processing (2)
  • lambdapdk/gt2n/__init__.py
  • lambdapdk/interposer/__init__.py
📝 Walkthrough

Walkthrough

This PR removes registration of corner-specific Tcl PEX RC files and the "openroad-openrcx" PEX model fileset from the ASAP7, FreePDK45, GF180, IHP130, and Sky130 PDK init scripts, keeping only the ".rules" openrcx registration and the "openroad" PEX model fileset. Corresponding Tcl RC rule files are deleted across these PDKs.

Changes

Remove openroad-openrcx Tcl PEX registration

Layer / File(s) Summary
PDK init scripts drop tcl/openrcx-model registration
lambdapdk/asap7/__init__.py, lambdapdk/freepdk45/__init__.py, lambdapdk/gf180/__init__.py, lambdapdk/ihp130/__init__.py, lambdapdk/sky130/__init__.py
Each PDK's OpenROAD PEX setup no longer adds the per-corner .tcl file or registers the openroad-openrcx PEX model fileset; only the .rules file (openrcx) and the openroad PEX model fileset remain.
Deleted RC rule Tcl files
lambdapdk/asap7/base/pex/openroad/typical.tcl, lambdapdk/freepdk45/base/pex/openroad/typical.tcl, lambdapdk/gf180/base/pex/openroad/*.tcl, lambdapdk/gt2n/base/pex/openroad/typical.tcl, lambdapdk/ihp130/base/pex/openroad/typical.tcl, lambdapdk/interposer/base/pex/openroad/*.tcl, lambdapdk/sky130/base/pex/openroad/{minimum,typical,maximum}.tcl
Tcl files defining set_layer_rc RC parameters for metal layers and vias across corners are removed with no replacement content.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is related to the change, but it is too vague to clearly describe the specific PEX cleanup across multiple PDKs. Use a more specific title, e.g. "Remove legacy OpenROAD PEX RC rule files" or similar.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pex23

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gadfort gadfort merged commit e6f6b20 into main Jul 9, 2026
4 checks passed
@gadfort gadfort deleted the pex23 branch July 9, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant