Skip to content

Fix Whisper STT LiveKit connection options#16

Merged
Duvet05 merged 1 commit into
mainfrom
fix-whisper-stt-livekit-options
Jul 6, 2026
Merged

Fix Whisper STT LiveKit connection options#16
Duvet05 merged 1 commit into
mainfrom
fix-whisper-stt-livekit-options

Conversation

@Duvet05

@Duvet05 Duvet05 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Update local Whisper STT adapter to accept LiveKit Agents conn_options in _recognize_impl.
  • Preserve NOT_GIVEN language handling so configured STT language is still used by default.
  • Add a regression test for the LiveKit STT method signature.

Why

Server logs showed the agent had STT_PROVIDER=whisper configured, but STT failed at runtime with:
WhisperSTT._recognize_impl() got an unexpected keyword argument 'conn_options'

Validation

  • .venv/bin/pytest tests/test_local_providers.py tests/test_session.py tests/test_agent_entrypoint.py -q
  • .venv/bin/ruff check src/local_stt.py tests/test_local_providers.py
  • python3 -m py_compile src/local_stt.py tests/test_local_providers.py

Note: mypy src/local_stt.py still fails locally because faster_whisper is missing stubs/import metadata in the local env; unrelated to this signature fix.


View with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is enabled.

Copilot AI review requested due to automatic review settings July 6, 2026 03:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Duvet05
Duvet05 merged commit 2c2b684 into main Jul 6, 2026
5 checks passed
@Duvet05
Duvet05 deleted the fix-whisper-stt-livekit-options branch July 6, 2026 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants