Label the postpone submit with Kirby's standard Save - #64
Merged
Conversation
The entry points keep saying "Keep longer" — intent naming for the 99% case, like "Empty trash". But the dialog can also shorten the retention or switch to indefinite keeping, and the submit button sits exactly where that choice is made, so it now uses Kirby's core 'save' translation instead of repeating the intent label. No new translation keys; correct in every Panel language.
Unlike fixes to unreleased features, this adjusts behavior that shipped with 0.6.0, so it gets a bullet.
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the postpone dialog submit label to use Kirby’s standard localized “Save” label, improving wording accuracy when users shorten retention or switch to indefinite keeping.
Changes:
- Update the postpone dialog submit button text to
I18n::translate('save'). - Add an explanatory inline comment near the submit button config.
- Add a new CHANGELOG entry for 0.6.1 (unreleased) describing the wording change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| index.php | Changes the postpone dialog submit button label to Kirby’s standard “Save” i18n key. |
| CHANGELOG.md | Adds an unreleased 0.6.1 note describing the submit-label change. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+3
to
10
| ## 0.6.1 (unreleased) | ||
|
|
||
| - The postpone dialog's submit button says "Save" instead of | ||
| repeating "Keep longer" — the dialog can also shorten the | ||
| retention or switch to indefinite keeping, and the button sits | ||
| exactly where that choice is made | ||
|
|
||
| ## 0.6.0 (2026-08-19) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer feedback on the v0.6.0 wording: "Keep longer" isn't 100% accurate — the dialog can also shorten the retention (any date from tomorrow on) or switch to indefinite keeping.
Resolution (the hybrid the maintainer picked): the entry points keep "Keep longer" — intent naming for the 99% case, same register as "Empty trash" — while the dialog's submit button becomes Kirby's standard "Save" (core
savei18n key: no new translation strings, correct in every Panel language). That fixes the label exactly where it was most wrong: at the moment of submitting a shorter date or the indefinite toggle.Since this adjusts behavior that shipped with 0.6.0, the CHANGELOG gets a new
0.6.1 (unreleased)section with the entry — the maintainer opted for a quick 0.6.1 release right after this merges.🤖 Generated with Claude Code
https://claude.ai/code/session_01K2A6tmJVCMhNHrVCsR6zCK