fix: Support cosign v3 signature verification - #1968
Open
JasonPowr wants to merge 1 commit into
Open
Conversation
Signed-off-by: JasonPowr <japower@redhat.com>
JasonPowr
marked this pull request as ready for review
May 8, 2026 09:21
Contributor
Author
|
@hectorj2f Sorry for the direct ping :), I seen you reviewed and approved the last pr that was merged into this repo, when you have the time, Could I get a review please :), thanks in advanced |
Contributor
Author
|
@codysoyland Thank you so much for the review on my other pr !, when you have a minute could I also get a review on this one ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix LogID encoding to store raw bytes instead of hex-encoded ASCII. cosign.GetTransparencyLogID() returns a hex string the old code stored it via []byte(logID) (ASCII bytes of the hex chars) instead of hex.DecodeString(logID) (actual binary). This caused key-lookup mismatches with sigstore-go / cosign v3.
Fix transparency log public key map lookups to use hex.EncodeToString() instead of string() on the now-correct raw byte LogIDs.
Add bundle-format verification path for keyless and RFC3161Timestamp authorities, routing to attestation verification when NewBundleFormat is set.
Release Note
Documentation
Users verifying cosign v3 bundle-format signatures can now set
signatureFormat: "bundle"on a keyless authority in their ClusterImagePolicy. No changes are required for existing policies using the legacy signature format.Custom TrustRoot configurations with transparency log entries (Rekor/CTFE) will now produce correctly encoded LogIDs. Existing TrustRoot resources should be re-reconciled after upgrading to ensure LogIDs are stored in the correct format.