docs: remove obsolete COSIGN_EXPERIMENTAL=1 from keyless attest example#442
Open
mailnike wants to merge 1 commit into
Open
docs: remove obsolete COSIGN_EXPERIMENTAL=1 from keyless attest example#442mailnike wants to merge 1 commit into
mailnike wants to merge 1 commit into
Conversation
Keyless signing and attestation is the default since cosign v2, so the COSIGN_EXPERIMENTAL=1 environment variable is no longer required for the cosign attest example. Closes sigstore#440. Signed-off-by: Nikhil Jathar <22786232+mailnike@users.noreply.github.com>
✅ Deploy Preview for docssigstore ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
policy-controller/sample-policies.mdSBOM example setsexport COSIGN_EXPERIMENTAL=1before a keylesscosign attestcall. Keyless signing/attestation has been the default since cosign v2, so this variable is no longer required and is misleading for anyone on a current cosign release.Per the cosign
CHANGELOG.md:COSIGN_EXPERIMENTAL=1is no longer required to have identity-based ("keyless") signing and transparency.This removes the stale
exportline; thecosign attestcommand is unchanged and already signs keylessly against the public Fulcio root.Closes #440.