Remove unused ephemeral signer - #4938
Merged
Merged
Conversation
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4938 +/- ##
==========================================
- Coverage 40.10% 38.79% -1.31%
==========================================
Files 155 221 +66
Lines 10044 13581 +3537
==========================================
+ Hits 4028 5269 +1241
- Misses 5530 7547 +2017
- Partials 486 765 +279 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
It looks like unrelated to this pull request there might be an issue in https://github.com/sigstore/scaffolding? From the failed e2e workflow run: |
Contributor
|
transparency-dev/witness#548 might have broken the test, since we're pulling in the witness from HEAD. |
Contributor
|
I'm looking into the witness failure now, it's impacting local testing as well. |
Contributor
|
oh hah it was just the |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change removes the unused
ephemeralSignerimplementation.