Conversation
| @@ -6792,8 +6792,14 @@ impl<T: BeaconChainTypes> BeaconChain<T> { | |||
| }; | |||
|
|
|||
| let inclusion_list_transactions = if prepare_slot_fork.heze_enabled() { | |||
There was a problem hiding this comment.
looks like this branch gets skipped when we already have the attributes cached for (prepare_slot, head_root, payload_status). fork choice calls prepare_beacon_proposer pretty early in the slot, so in practice the entry gets created before the ILs arrive and then the fcU keeps sending that same stale list for the rest of the slot.
block production reads the store again, so the list itself is fine. but I think we'd still want to handle the cache case here, or maybe follow it up separately?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
This PR is part of the FOCIL implementation. It finishes the proposer side wiring of
engine_forkchoiceUpdatedV5by populating theinclusion_list_transactionsfield inPayloadAttributesV5(per spec).Proposed Changes
inclusion_list_transactionsrequired in thePayloadAttributesV5built in the block production code paths:prepare_beacon_proposer, the warm-up fcU call sent before the node's proposal slotprepare_execution_payloadin the block productionBeaconChain::get_inclusion_list_transactionsfor fetching inclusion lists for the proposer code paths (forslot. - 1, both timely and untimely transactions, as the spec requires). The helper returns an empty transactions list in case of error, so a store read failure never affects block production