test: clarify qbft_manager harness setup - #917
Draft
diegomrsantos wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem, Evidence, and Context (Required)
qbft_managertests currently hide simple scenarios behind generic setup and generic harness entrypoints, which makes behavior-focused reviews harder than they need to be.setup_test(...), rawTestContext::new(...), andverify_consensus()to understand straightforward scenarios like "start one instance and assert consensus".Change Overview (Required)
qbft_managertests use intent-named helpers for runtime setup, beacon-vote cluster startup, and consensus assertions.Risks, Trade-offs, and Mitigations (Required)
qbft_managertest crate still passes after the refactor.Validation (Required)
cargo test -p qbft_managercargo fmt --all --checkcargo fmt --all,cargo clippy --all,cargo sort workspaceRollback (Required for behavior or runtime changes; optional otherwise)
Blockers / Dependencies (Optional)
unstable; rebasing before merge should be straightforward because the PR only touches one test file.Additional Info / Next Steps (Optional)
qbft_managertest and lifecycle changes can build on clearer test intent.