merge queue: checking unstable (f685f21) and #1229 together - #1246
Closed
mergify[bot] wants to merge 3 commits into
Closed
merge queue: checking unstable (f685f21) and #1229 together#1246mergify[bot] wants to merge 3 commits into
mergify[bot] wants to merge 3 commits into
Conversation
…nce per slot Both Boole post-consensus callbacks sized the committee partial-signature batch from the full decided value but each signed only its own object class, so any decided entry whose class the local Lighthouse did not request left the batch permanently under-filled and the operator's single post-consensus message was never sent. The whole duty then failed cluster-wide. Drive the signing from the decided value instead. The slot pipeline starts one execution per committee when it publishes that value at 2/3 slot, so exactly one message per (committee, slot) holds by construction rather than by locking, and the two Lighthouse callbacks become lookups that filter the shared outcome for the roots they asked for. The batch size is the number of entries actually submitted, so it is always reachable by local filtering. This reuses the crate's existing signing pipeline rather than duplicating it: SigningRequest and resolve now key results by (validator index, signing root) so one validator can hold five distinct roots, and collect_prepared_signatures shares the drain helper with the new path. collect_signature is unchanged. Refs #1227
Registering an AggregatorCommittee execution overwrote any existing entry for the same (committee, slot). The slot pipeline publishes once per slot today, so this was not reachable, but it moved the exactly-once guarantee out of this module and into another module's timing loop. Overwriting would spawn a second QBFT round and a second set of detached signing tasks while the first set kept running, putting two post-consensus messages on the wire for one slot, which peers reject with a gossip penalty. Register only into a vacant entry so exactly-once holds here regardless of how often the pipeline publishes, and correct the field doc, which still described the superseded callback-triggered design. Raised in review of #1229.
|
Your PR title doesn't follow the Conventional Commit guidelines. Example of valid titles:
Usage:
Breaking Changes Breaking changes are noted by using an exclamation mark. For example:
Help For more information, follow the guidelines here: https://www.conventionalcommits.org/en/v1.0.0/ |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## unstable #1246 +/- ##
============================================
+ Coverage 68.30% 69.42% +1.11%
============================================
Files 164 166 +2
Lines 28817 29540 +723
============================================
+ Hits 19684 20508 +824
+ Misses 9133 9032 -101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch unstable (f685f21) and #1229 are queued together for merge.
This pull request has been created by Mergify to check the mergeability of #1229.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:check-success=cli-reference-checkcheck-success=run-local-testnetcheck-success=test-suite-successgithub-review-approved[🛡 GitHub repository ruleset ruleunstable and release-v*]unstable and release-v*]:check-success = license/clacheck-neutral = license/clacheck-skipped = license/claRequired conditions to stay in the queue:
#approved-reviews-by >= 1check-success=license/clacheck-success=target-branch-checkgithub-review-approved[🛡 GitHub repository ruleset ruleunstable and release-v*]label!=do-not-mergeunstable and release-v*]:check-success = license/clacheck-neutral = license/clacheck-skipped = license/cla