fix: tolerate unknown proposer duties without spawning QBFT - #1199
Draft
shane-moore wants to merge 3 commits into
Draft
fix: tolerate unknown proposer duties without spawning QBFT#1199shane-moore wants to merge 3 commits into
shane-moore wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## epbs #1199 +/- ##
==========================================
+ Coverage 71.95% 72.32% +0.37%
==========================================
Files 168 168
Lines 33797 34009 +212
==========================================
+ Hits 24317 24597 +280
+ Misses 9480 9412 -68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
shane-moore
force-pushed
the
fix/1190-manager-owned-qbft-gate
branch
from
August 10, 2026 19:27
335bd46 to
a24bfef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem, Evidence, and Context (Required)
An absent proposer-duty schedule is not evidence that a validator has no duty. The current proposer path can therefore reject honest inbound messages when local duty data or validator indices are missing. Simply accepting those messages is also unsafe if network input can allocate an unverified QBFT instance.
Closes #1190.
Change Overview (Required)
Assigned,Unknown, andNotAssignedcontract.AssignedandUnknown; returnNoDutyonly for authoritativeNotAssigned.QbftManager::receive_network_message:Assignedmay create an instance,Unknowncan use only an existing instance, andNotAssigneddrops before map access.No wire, topic, fork-schedule, database, or configuration change is included.
Risks, Trade-offs, and Mitigations (Required)
Unknownmessage with no existing instance is accepted by gossip validation but dropped locally without buffering. Replay and count state has already been consumed, so the same message is not deferred for later delivery.EnvelopeProposerhas no local QBFT initializer today, so itsUnknownpath is normally drop-only.The manager owns the gate at the typed-map routing boundary.
ExistingOnlyperforms one lookup without falling through to allocation, and tests cover both proposer roles, all verdict transitions, exact-key isolation, fork gating, and unchanged controls.Validation (Required)
cargo test -p duties_tracker -p message_validator -p qbft_manager -p message_receiver --no-fail-fastcargo check -p clientmake cargo-fmt-checkmake lintmake testRollback (Required for behavior or runtime changes; optional otherwise)
Revert this PR. It has no persistent-data, configuration, or wire-format migration.
Blockers / Dependencies (Optional)
Keep as draft until:
NotAssignedevidence.