chore: satisfy Rust 1.97 useless_borrows_in_formatting lint - #1127
Merged
Conversation
Rust 1.97 tightened clippy::useless_borrows_in_formatting, which now fires on two pre-existing redundant references passed to write!/format! macros. Drop the redundant `&` in the logging span formatter and the eth sync WS-bind error so `check-code` passes across all open PRs.
shane-moore
force-pushed
the
chore/clippy-rust-1-97
branch
from
July 10, 2026 01:37
4f5c72a to
84d9950
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1127 +/- ##
=========================================
Coverage 62.62% 62.63%
=========================================
Files 161 161
Lines 26925 26922 -3
=========================================
Hits 16862 16862
+ Misses 10063 10060 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jnhsigmap
approved these changes
Jul 10, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem, Evidence, and Context
check-codejob runsmake lintagainst the latest stable Rust, which is now 1.97 (released 2026-07-07). Rust 1.97 tightenedclippy::useless_borrows_in_formatting, which now fires on two pre-existing redundant references passed towrite!/format!macros.unstable,check-codeis currently red on every open PR (e.g. feat: instruments proposer QBFT lifecycle #1105), not any single feature branch.cargo clippy --workspace --testsunder 1.97 fails withredundant reference in write!/format! argumentatlogging/src/format.rs:204andeth/src/sync.rs:166.Change Overview
&in two format-macro arguments:logging/src/format.rsspan-fields formattereth/src/sync.rsWS-bind error messageRisks, Trade-offs, and Mitigations
Displayoutput is identical whether the value is borrowed or not; the&was always redundant.Validation
make lint(clippy under Rust 1.97) passes clean across the full workspace after the change.cargo fmt --checkpasses.Rollback