This repository was archived by the owner on Feb 12, 2022. It is now read-only.
pkg-config file updates: 'Libs: -lm' + no '/signal' in 'Cflags: -I' - #130
Open
fbrausse wants to merge 1 commit into
Open
pkg-config file updates: 'Libs: -lm' + no '/signal' in 'Cflags: -I'#130fbrausse wants to merge 1 commit into
fbrausse wants to merge 1 commit into
Conversation
…don't include /signal in the '-I' option (namespace pollution)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
when linking using the
pkg-configfile,-lmis missing. As far as I can see it is used only once:libsignal-protocol-c/src/hkdf.c
Line 109 in 71954c5
-lmto thepkg-configfile.It also removes the trailing path component
/signalfor the-Ioption inlibsignal-protocol-c.pc.in, as this leads to "namespace pollution" in the sense that everypkg-configuser of this library cannot use the file names of any header filelibsignal-protocol-cprovides (which are quite many). Leaving the path prefixed bysignal/on the client side is cleaner (and also what other libraries'pkg-configfile exports, e.g., OpenSSL has its headers ininclude/openssl/but does not include the suffix in its-Ioption).Thanks for your consideration.