test: skip podcast search results without a browseId - #976
Merged
Conversation
The podcasts search filter can surface non-podcast results (e.g. episodes) that lack a browseId, causing get_podcast() to crash with an AttributeError.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #976 +/- ##
==========================================
+ Coverage 95.77% 95.81% +0.03%
==========================================
Files 47 47
Lines 2723 2723
==========================================
+ Hits 2608 2609 +1
+ Misses 115 114 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_many_podcastscallsyt.search("europe", filter="podcasts")and passes every result'sbrowseIdstraight intoget_podcast().podcastsfilter can surface results (e.g. episodes) that don't have abrowseId, sinceytmusicapi/parsers/search.py:65reads it withnone_if_absent=True.get_podcast(None)raisesAttributeError: 'NoneType' object has no attribute 'startswith'inytmusicapi/mixins/podcasts.py:136, failing CI (seen on PR Expose ownership for library playlists #972: https://github.com/sigma67/ytmusicapi/actions/runs/31269845020/job/93133837902).test_many_episodesright below already tolerates a similar case (episodes that are no longer available); this applies the same pattern here.Test plan
ruff check/ruff format/mypypass via pre-commit hooks