Skip to content

feat: add configurable OIDC provider display name - #124

Merged
max-wittig merged 2 commits into
siemens:masterfrom
groundsgg:feat/configurable-oidc-provider-name
Jul 8, 2026
Merged

feat: add configurable OIDC provider display name#124
max-wittig merged 2 commits into
siemens:masterfrom
groundsgg:feat/configurable-oidc-provider-name

Conversation

@lusu007

@lusu007 lusu007 commented Jun 19, 2026

Copy link
Copy Markdown

What changed

This adds an OIDC_PROVIDER_NAME setting that controls the user-facing OIDC provider name shown in Sentry.
By default the provider is still displayed as OIDC. Installations can now set, for example:

OIDC_PROVIDER_NAME = "Acme Corp SSO"

The provider key remains stable as oidc, so existing Sentry template classes such as .provider-logo.oidc and .btn-login-oidc remain predictable for custom styling.

Why this PR

This supersedes #74. That PR was opened by Copilot and still contained generated-agent footer text and documentation that implied the icon CSS class was derived from the display name. I opened this replacement PR from a reviewed branch so the implementation and docs match Sentry's actual template behavior: the display text is configurable, while the CSS hook remains the provider key.

Details

  • Uses the same display name in the OIDC configure view.
  • Documents the stable .provider-logo.oidc icon hook.
  • Adds an example icon and regression coverage for the configure view context.

Fixes #19.

Validation

  • uv run ruff check .
  • uv run ruff format --check .
  • Previously verified uv run pytest tests/test_provider.py locally with the required services.
  • Also smoke-tested a temporary local Sentry instance

@CLAassistant

CLAassistant commented Jun 19, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the OIDC_PROVIDER_NAME configuration option to allow customization of the OIDC provider's display name in the Sentry UI, along with documentation and an example SVG icon for custom branding. The review feedback suggests falling back to ISSUER in oidc/constants.py to prevent a regression for existing installations that relied on OIDC_ISSUER as the display name. Additionally, the documentation in examples/README.md should be updated to provide the correct base64 command for macOS users, as the GNU-specific -w flag is not supported on BSD-based systems.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread oidc/constants.py Outdated
Comment thread examples/README.md Outdated
@lusu007
lusu007 force-pushed the feat/configurable-oidc-provider-name branch from 788dbb1 to 908c3e2 Compare June 19, 2026 18:12
Comment thread docs/custom-provider-icon.md Outdated
@lusu007
lusu007 force-pushed the feat/configurable-oidc-provider-name branch from 3558be2 to d30831b Compare June 22, 2026 21:20
@lusu007
lusu007 force-pushed the feat/configurable-oidc-provider-name branch from d30831b to d4c3f3b Compare June 22, 2026 21:22
@max-wittig

Copy link
Copy Markdown
Member

Sorry for the late response @lusu007. Would you mind rebasing again?

Copilot AI review requested due to automatic review settings July 7, 2026 13:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@max-wittig
max-wittig merged commit 8d6c76d into siemens:master Jul 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

custom icon

4 participants