feat: add configurable OIDC provider display name - #124
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the OIDC_PROVIDER_NAME configuration option to allow customization of the OIDC provider's display name in the Sentry UI, along with documentation and an example SVG icon for custom branding. The review feedback suggests falling back to ISSUER in oidc/constants.py to prevent a regression for existing installations that relied on OIDC_ISSUER as the display name. Additionally, the documentation in examples/README.md should be updated to provide the correct base64 command for macOS users, as the GNU-specific -w flag is not supported on BSD-based systems.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
788dbb1 to
908c3e2
Compare
3558be2 to
d30831b
Compare
d30831b to
d4c3f3b
Compare
|
Sorry for the late response @lusu007. Would you mind rebasing again? |
What changed
This adds an
OIDC_PROVIDER_NAMEsetting that controls the user-facing OIDC provider name shown in Sentry.By default the provider is still displayed as
OIDC. Installations can now set, for example:The provider key remains stable as oidc, so existing Sentry template classes such as
.provider-logo.oidcand.btn-login-oidcremain predictable for custom styling.Why this PR
This supersedes #74. That PR was opened by Copilot and still contained generated-agent footer text and documentation that implied the icon CSS class was derived from the display name. I opened this replacement PR from a reviewed branch so the implementation and docs match Sentry's actual template behavior: the display text is configurable, while the CSS hook remains the provider key.
Details
Fixes #19.
Validation