Accessibility Guideline V1 - #29
Merged
Merged
Conversation
✅ Deploy Preview for industrial-experience ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
danielleroux
marked this pull request as draft
June 16, 2025 11:16
kathrinschalber
requested changes
Jun 17, 2025
Co-authored-by: Kathrin <123640803+kathrinschalber@users.noreply.github.com>
Co-authored-by: Kathrin <123640803+kathrinschalber@users.noreply.github.com>
Co-authored-by: Kathrin <123640803+kathrinschalber@users.noreply.github.com>
Co-authored-by: Kathrin <123640803+kathrinschalber@users.noreply.github.com>
Co-authored-by: Kathrin <123640803+kathrinschalber@users.noreply.github.com>
- removed primary restriction - removed oval option since it is mentioned in the icon-button guide - removed not needed comma
+ fixed line-breaks, removed trailing spaces, removed broken example
kathrinschalber
previously approved these changes
Jul 15, 2025
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 21.1.1 to 22.0.0. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](octokit/rest.js@v21.1.1...v22.0.0) --- updated-dependencies: - dependency-name: "@octokit/rest" dependency-version: 22.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [autoprefixer](https://github.com/postcss/autoprefixer) from 10.4.5 to 10.4.21. - [Release notes](https://github.com/postcss/autoprefixer/releases) - [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md) - [Commits](postcss/autoprefixer@10.4.5...10.4.21) --- updated-dependencies: - dependency-name: autoprefixer dependency-version: 10.4.21 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daniel Leroux <daniel.leroux@siemens.com>
tokyojen
reviewed
Jul 22, 2025
tokyojen
left a comment
tokyojen
left a comment
Collaborator
There was a problem hiding this comment.
No changes recommended. Ready to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, this is the first version of the new a11y guidelines. I have included placeholders (add example here text), where I think we could add some iX specific examples after we are done with fixing our components to properly support the a11y attributes.
JIRA: IX-2656