fixup(list-item): support an indicator#2287
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for an optional indicator column in the list item component by updating its CSS grid layout and updating the examples to demonstrate the new indicator. Feedback on the changes suggests removing a redundant elementPlant property in the TypeScript component and removing an unnecessary wrapper div around the status icon in the HTML template.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| ]; | ||
| protected readonly elementPlant = elementPlant; | ||
| } |
There was a problem hiding this comment.
| </li> | ||
|
|
||
| <li class="list-item"> | ||
| <div class="list-item-indicator"><si-status-icon class="icon" status="danger" /></div> |
There was a problem hiding this comment.
The si-status-icon component is wrapped in a redundant div with the class list-item-indicator. Since si-status-icon is an Angular component, you can apply the list-item-indicator class directly to it, avoiding an unnecessary DOM element and keeping the template cleaner.
| <div class="list-item-indicator"><si-status-icon class="icon" status="danger" /></div> | |
| <si-status-icon class="list-item-indicator" status="danger" /> |
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: