Daily challenge - #117
Merged
Merged
Conversation
POST /game/daily returns the code of today's challenge: it creates the game on the first call of the day and returns the existing one after that, so a player gets a single attempt per Swiss day. The seed and forced decks live on a per-day daily_challenge row, so everybody plays the exact same cards. Game creation and seating moved into a shared GameService.startGame used by both custom and daily games.
|
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Kotlin | Jul 31, 2026 7:05p.m. | Review ↗ | |
| Code coverage | Jul 31, 2026 7:05p.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (New Code) | Line Coverage (Overall) |
|---|---|---|
| Aggregate | 26% |
68% [▼ down 1.7% from master] |
| Kotlin | 26% |
68% [▼ down 1.7% from master] |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
The lobby becomes a tabbed carousel under /lobby/:section with daily, join and create, so the daily challenge has a home and the deep link survives back navigation. Join and create move out of main-screen into their own sections, create-game-overlay becomes create-section.
sidneywidmer
force-pushed
the
feature/daily-challenge
branch
from
July 31, 2026 19:05
54a7b0e to
8e55e1b
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cool new feature that existed for a long time on my liste where all players play the exact same hand to see who's actually the best of the best :) Obviously has huge cheating potential by just using two accounts but thats a problem for future me when more players use the daily challenge.
These changes made this possible: