Skip to content

Daily challenge - #117

Merged
sidneywidmer merged 3 commits into
masterfrom
feature/daily-challenge
Jul 31, 2026
Merged

Daily challenge#117
sidneywidmer merged 3 commits into
masterfrom
feature/daily-challenge

Conversation

@sidneywidmer

@sidneywidmer sidneywidmer commented Jul 31, 2026

Copy link
Copy Markdown
Owner

Cool new feature that existed for a long time on my liste where all players play the exact same hand to see who's actually the best of the best :) Obviously has huge cheating potential by just using two accounts but thats a problem for future me when more players use the daily challenge.

These changes made this possible:

image

POST /game/daily returns the code of today's challenge: it creates the
game on the first call of the day and returns the existing one after that,
so a player gets a single attempt per Swiss day.

The seed and forced decks live on a per-day daily_challenge row, so
everybody plays the exact same cards. Game creation and seating moved into
a shared GameService.startGame used by both custom and daily games.
@deepsource-io

deepsource-io Bot commented Jul 31, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in ce14623...8e55e1b on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
Kotlin Jul 31, 2026 7:05p.m. Review ↗
Code coverage Jul 31, 2026 7:05p.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
26%
68%
[▼ down 1.7% from master]
Kotlin
26%
68%
[▼ down 1.7% from master]

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

The lobby becomes a tabbed carousel under /lobby/:section with daily, join
and create, so the daily challenge has a home and the deep link survives
back navigation. Join and create move out of main-screen into their own
sections, create-game-overlay becomes create-section.
@sidneywidmer
sidneywidmer force-pushed the feature/daily-challenge branch from 54a7b0e to 8e55e1b Compare July 31, 2026 19:05
@sidneywidmer
sidneywidmer merged commit be6f28d into master Jul 31, 2026
2 of 4 checks passed
@sidneywidmer
sidneywidmer deleted the feature/daily-challenge branch July 31, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant