Skip to content

fix(editor): fix horizontal rule not allowing input on empty editor (#635) - #642

Open
paulirwin wants to merge 1 commit into
sibiraj-s:masterfrom
paulirwin:issue/635
Open

fix(editor): fix horizontal rule not allowing input on empty editor (#635)#642
paulirwin wants to merge 1 commit into
sibiraj-s:masterfrom
paulirwin:issue/635

Conversation

@paulirwin

Copy link
Copy Markdown
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • others

Breaking Changes?

  • yes
  • no

Checklist

  • commit messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
    • A document related commit is prefixed "docs:"
  • docs have been added / updated (for bug fixes / features)

Describe Your Changes

Fixes a few issues that occur when you add a horizontal rule from the toolbar with an empty editor.

Does this PR affects any existing issues?

  • yes
  • no

Fixes #635

@paulirwin

Copy link
Copy Markdown
Contributor Author

For anyone that needs this fix, this is now included in v21.1.0 in our experimental fork here: https://www.npmjs.com/package/@feature23/ngx-editor/v/21.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Issues with horizontal rule on empty editor

1 participant