Skip to content

Angular 21 + Zoneless - #637

Open
bobbyquantum wants to merge 3 commits into
sibiraj-s:masterfrom
bobbyquantum:ng21
Open

Angular 21 + Zoneless#637
bobbyquantum wants to merge 3 commits into
sibiraj-s:masterfrom
bobbyquantum:ng21

Conversation

@bobbyquantum

Copy link
Copy Markdown

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • others

Breaking Changes?

  • yes
  • no

Checklist

  • commit messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
    • A document related commit is prefixed "docs:"
  • docs have been added / updated (for bug fixes / features)

Describe Your Changes

βœ… Angular 21 support
βœ… Zoneless change detection (provideZonelessChangeDetection())
βœ… OnPush change detection for all components
βœ… Angular Signals for reactive state
βœ… Modern control flow (@if, @for instead of *ngIf, *ngFor)
βœ… inject() pattern instead of constructor injection
βœ… Ctrl/Cmd+Click to open links in editor

Does this PR affects any existing issues?

  • yes
  • no

Partial fix for #636 (adds Angular 21, but not 19 or 20 support)

Fixes #614 (issues with change detection in zoneless, which was also preventing image resize in that mode)

Partial fix for #602 (adds a ctrl/mod + click shortcut to open links. Direct navigation on click when editing text is too abrupt, whereas requiring ctrl/mod+click requires intention, and matches up with other software where links can be embedded.


Looking at activity on this library, it seems that this PR is fairly unlikely to get merged, so I've also pushed a scoped fork up, if anyone would like to try out using zoneless Angular 21:

npm install @bobbyquantum/ngx-editor

Also stackblitz webcontainer here:
https://stackblitz.com/edit/stackblitz-starters-7jpjrzav?file=src%2Fapp.component.ts

The scoped package version is on branch main of my fork, but I will keep branch ng21 unscoped for reference of the changes.

I hope this PR is of some use if Angular 21 support is ever added, and thanks for work on this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Zoneless application active menu buttons

1 participant