feat: add full HTML table supprt using ProseMirror - #610
Open
osaydayoub wants to merge 2 commits into
Open
Conversation
|
Hey @osaydayoub thanks for your work, we also need this. @sibiraj-s Is there a chance that this feature will be available in the near future? Thanks |
Author
|
Hi @sibiraj-s , just checking in to see if there are any updates on this PR. Happy to make adjustments if needed to get it merged. Thanks! |
Owner
|
Apologies. got busy with work. Will take a look this weekend and publish if everything is fine. |
|
+1 |
+1 |
|
+1 |
|
@sibiraj-s Is there any chance to get this in the next version? We would really need the table functionallity ^^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
Checklist
Describe Your Changes
Hi, I'm Osayd, a computer science student in my final semester. As part of my industrial project with Dell Technologies,
I was tasked with adding full HTML table support to ngx-editor, which is used by Dell’s internal documentation sites.
This feature includes:
A new Table menu button and dropdown for table editing
Real table insertion using
prosemirror-tablesTable resizing, keyboard navigation (Tab), and other plugins
All files organized to align with the existing module structure
I previously shared this plan in this comment on May 6, but haven’t received a reply yet. Now that the feature is ready and working locally, I’d like to open this PR for your review.
Demo video: https://youtu.be/CkVnP75ouOk
I’d be happy if this feature could be added to the project. Let me know if I need to make any changes to better follow the project’s contribution guidelines — including tests, commit messages, documentation, or anything else.
Thanks !
Osayd
Does this PR affects any existing issues?