Skip to content

chore(deps): autoupdate (needs claude fix) - #31

Merged
github-actions[bot] merged 3 commits into
masterfrom
chore/autoupdate-36199315290
Sep 25, 2026
Merged

github-actions[bot] merged 3 commits into
masterfrom
chore/autoupdate-36199315290

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

The dependency autoupdater failed during builds-and-checks.

Run log: https://github.com/siarheidudko/firebase-engine/actions/runs/36199315290

A Claude session has been dispatched to push fixes onto this branch
so the following commands all exit 0:

  npm run lint
  npm run build
  npm run cov

Claude will leave a status comment on this PR when it finishes.
The Claude workflow re-dispatches PR-checks once it is done, so the
checks below reflect its pushed fixes.

@github-actions github-actions Bot added autoupdate Automated dependency update PRs needs-claude Needs Claude GitHub App to fix labels Sep 25, 2026
…rage 8.x

The updated @google-cloud/storage client returns a false negative from
bucket.exists() against the Storage emulator, so JobRestoreStorage always
attempted bucket.create(), which itself fails against the emulator and
leaves behind a phantom bucket that breaks later clean/backup operations.
Check bucket existence via getBuckets() instead, which works correctly
against both the emulator and the updated client.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@claude

claude Bot commented Sep 25, 2026

Copy link
Copy Markdown

Status: fixed and pushed — commit f38adb6.

What failed initially: npm run lint and npm run build were already green. npm run cov failed: with the bumped @google-cloud/storage (7.21.0 → 8.2.0), Bucket.exists() started returning a false negative against the Storage emulator (the bucket really exists — confirmed via getBuckets() — but the metadata-fetch under exists() gets a 404 from the emulator with the new client). src/jobs/restore/storage.ts used that false exists() result to call bucket.create(), which itself fails against the emulator (Bad Request: Content-Type must be multipart/form-data) but as a side effect leaves behind a phantom bucket named "b". That phantom bucket then broke later clean.storage() calls in the same test run (Not Implemented / Storage is empty! failures in test/integration/cli.test.js and test/integration/library.test.js).

Fix: In src/jobs/restore/storage.ts, replaced the bucket.exists() check with a getBuckets()-based existence check (list buckets and look for a name match), which works correctly against both the emulator and the updated client. No product-facing behavior change — same intent (create the bucket if it doesn't already exist), just a working existence check. No dependency versions or package.json were touched.

Verification: Ran npm run lint, npm run build, and npm run cov (Firestore/Auth/Storage emulators) to completion (exit 0) on both Node 22 and Node 24 — 24/24 tests passing on each. (Note: this Claude session's environment doesn't set up JDK 21 or write serviceAccount.json the way pr-checks.yml/autoupdate.yml do, so I set JAVA_HOME to the runner's bundled Temurin 21 and used a locally-generated throwaway service-account key — gitignored, not committed — purely to exercise the Storage/Firestore/Auth emulators for verification.)

Pushed: commit f38adb6 on chore/autoupdate-36199315290.

@github-actions
github-actions Bot merged commit 77e6f95 into master Sep 25, 2026
3 checks passed
@github-actions
github-actions Bot deleted the chore/autoupdate-36199315290 branch September 25, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoupdate Automated dependency update PRs needs-claude Needs Claude GitHub App to fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant