Repository navigation
fix: correct PHPStan condition callback type - #924
Merged
Merged
Conversation
shyim
force-pushed
the
fix/phpstan-condition-callback
branch
from
November 3, 2026 06:33
723303e to
29078e5
Compare
shyim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declare the condition callback as
callable(Context): boolon the property and constructor parameter so PHPStan can verify its negated result. Runtime behavior is unchanged.Validation:
vendor/bin/phpstan analyse --no-progress— passes with no errors.vendor/bin/phpunit --no-coverage tests/Rule/ConditionTest.php— passes (2 tests, 2 assertions).