fix: remove deprecated concat_idents and fix all clippy warnings#461
Open
AlexMikhalev wants to merge 5 commits into
Open
fix: remove deprecated concat_idents and fix all clippy warnings#461AlexMikhalev wants to merge 5 commits into
AlexMikhalev wants to merge 5 commits into
Conversation
Remove concat_idents from nightly feature declarations as it was removed in Rust 1.90.0. The feature was not actually used in the codebase. Refs: design-plan.md Step 1
- Fix mismatched_lifetime_syntaxes in object.rs and state.rs - Fix mem_replace_option_with_some in state.rs - Fix dead_code warning for AutoCorrelatedSeries in series.rs - Fix derivable_impls for ChronoValueType and OutputState enums - Fix derivable_impls for Locale enum in faker.rs - Fix neg_multiply warnings in series.rs Refs: design-plan.md Step 2
Add #[allow(non_local_definitions)] to peek test that implements Generator trait for Vec<T> inside test function. Refs: design-plan.md Step 3
- Fix empty_line_after_doc_comments in mysql_datasource.rs - Fix manual_repeat_n in csv/mod.rs (use repeat_n instead) - Fix double_ended_iterator_last in mongo.rs (use next_back) - Fix extra_unused_lifetimes in mod.rs (remove unused 'w lifetime) Refs: design-plan.md Step 4
Replace ToString trait impl with Display for CommandResult to satisfy clippy warning when telemetry feature is enabled. Refs: design-plan.md Step 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes compilation on current Rust nightly by removing the deprecated `concat_idents` feature and resolving all clippy warnings.
Changes
Verification
Context
The `concat_idents` feature was removed in Rust 1.90.0. The project was using it in a feature declaration but never actually invoking the macro. This fix removes the feature flag to allow compilation on current nightly.
Closes compilation issues with Rust nightly 1.95.0+
Release Binaries (Fork)
Built and tested on fork: https://github.com/AlexMikhalev/synth/releases/tag/v0.6.9-fix
All binaries verified with: