Increase incoming msg buffer#714
Open
konradkonrad wants to merge 1 commit into
Open
Conversation
This change helps with concurrency issues on event based decryption triggers, when there are many registered decryption keys have to be generated at the same time. Experimentally this increase in buffer size helped to process (and broadcast) key shares for up to 250 registrations succesfully (in a 5 keyper scenario), whereas the previous setting starting failing at around 100 registrations. This addresses #715 For a more thorough fix, a (working) batching mechanism needs to be implemented (c.f. #700)
0cd8cf0 to
ed328b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change helps with concurrency issues on event based decryption triggers, when many registered decryption keys have to be generated at the same time. Experimentally this increase in buffer size helped to process (and broadcast) key shares for up to 250 registrations succesfully (in a 5 keyper scenario), whereas the previous setting starting failing at around 100 registrations.
This addresses #715
For a more thorough fix, a (working) batching mechanism needs to be implemented (c.f. #700)