fix: replace async setInterval with recursive setTimeout in VAD loop and participant polling - #886
fix: replace async setInterval with recursive setTimeout in VAD loop and participant polling#886Siddh2024 wants to merge 1 commit into
Conversation
…and participant polling Issue shouri123#876 identified two critical issues with async setInterval usage: 1. Unhandled promise rejections when async work in callbacks throws 2. Overlapping async executions when callback duration exceeds the interval Changes: - offscreen.ts: Convert VAD analysis loop from setInterval to recursive setTimeout pattern via new vadLoop() async function - content.ts: Convert participant polling from setInterval to recursive setTimeout pattern via pollParticipants() async function - Remove unused isVadBusy flag (no longer needed with recursive setTimeout which naturally serializes executions) - Add proper error logging with console.debug in content.ts polling - Ensure cleanup functions use clearTimeout instead of clearInterval
|
Warning Review limit reached
Next review available in: 52 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Thank You for Contributing to Late-MeetPlease ensure that:
Thank you for contributing 💙 |
|
👋 Thank you @Siddh2024 for your contribution to Late-Meet!
Please review any automated suggestions or code review comments that may appear below! We will review your PR as soon as possible! Please consider starring the repository ⭐ to show your support! |
|



Reliability fix: Replace async setInterval with recursive setTimeout in VAD loop and participant polling (#876)
Problem:
setInterval with async callbacks was used in two critical paths:
This caused:
Changes:
offscreen.ts:
content.ts:
Benefits: