Repository navigation
fix(installer): align static HTML and SVG CSP - #33
Merged
Merged
Conversation
This was referenced Oct 15, 2026
Member
|
we can skip this, the recipes will win |
Soner (shyim)
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
Static assets are served directly by the webserver and do not receive application response policies. HTML and SVG should use a consistent policy, scoped so that application-rendered pages and bundled HTML applications keep their existing behavior.
2. What does this change do, exactly?
Update
Resources/install-template/htaccessto mark only existing HTML files undermedia/andthumbnail/, and sendscript-src 'none'; object-src 'none'; frame-src 'none'; base-uri 'none'; form-action 'none'. Apply the same policy to SVG files. Keep the normal PHP rewrite path, bundled HTML applications and application-rendered HTML unchanged.Images and styles remain permitted. Custom static documents must work without scripts, embedded documents, base URL overrides or form submissions.
3. Describe each step to reproduce the issue or behaviour.
media/orthumbnail/, and an SVG file.Validation: Apache syntax and 15 real HTTP cases pass against this actual template, including subdirectory installation, uppercase extensions, SVG, query strings, bundled HTML and fixture PHP responses. Local Docker HTTP tests; no full installer run.
4. Please link to the relevant issues (if any).
5. Checklist