Repository navigation
chore: check for already splitted versions - #120
Closed
Jonas Elfering (keulinho) wants to merge 1 commit into
Closed
Jonas Elfering (keulinho) wants to merge 1 commit into
Jonas Elfering (keulinho) wants to merge 1 commit into
Conversation
Jonas Elfering (keulinho)
requested review from
Marcel Kräml (mkraeml) and
Philip Reinken (philipreinken)
December 1, 2025 13:46
| get_tags() { | ||
| git -c 'versionsort.suffix=-' ls-remote --exit-code --refs --sort='version:refname' --tags https://github.com/shopware/shopware 2>/dev/null | | ||
| cut --delimiter='/' --fields=3 | grep -v -i -E '(dev|beta|alpha)' | ||
| cut -d '/' -f 3 | grep -v -i -E '(dev|beta|alpha)' |
Contributor
Author
There was a problem hiding this comment.
the other format was not compatible with the cut implementation i had installed, so i assume this should have broader compatibility
Contributor
Author
|
With something like this where we have a defined point in time when the last scheduled branch split for a new minor version happened we can also execute the |
Contributor
Author
|
will close this for now, likely needs a bigger fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relying on dates to determine next version can be brittle and there might be cases where we do not use our regular schedule
instead i try to figure the next versions based on the release branches that already exist
I'm not sure if it is already working as expected, but i thought when we know our branching strategy we should be able to figure out in which state we are
one important thing that we should be able to figure out: when the final branch off for a release branch did happen we already need to update the next version so the next version should always contain the version that trunk is representing
Assumption was that we create a new release branch for the upcoming release as soon as we finally branch of for the current release, that was mainly based on the fact that even though we are still preparing 6.7.5.0 release, there is already a 6.7.6.x release branch
Happy to hear your thoughts, how we could achieve this the best